kevva / bin-build

Easily build binaries
MIT License
38 stars 13 forks source link

Update dependent module 'download' to more than 7 #15

Closed ghost closed 6 years ago

ghost commented 6 years ago

Hi! Thanks for your contribution!

When I tried 'npm install' (actually installing laravel-mix dependent libraries) under the proxy, 'MaxRedirectsError' occurred at the part accessing a resource via http instead of https. As I checked dependent library 'download' commit history, it's already merged as follows https://github.com/kevva/download/pull/158, but was with major version upgrade.

I would like you to migrate this change into this module, and keep the version '3.x.x'!!

Hopefully this propose is merged and if you have anything to me, please let me know.

Thank you,

bbbco commented 6 years ago

Notice, I already submitted the same fix here days ago: https://github.com/kevva/bin-build/pull/14

XhmikosR commented 6 years ago

This is a duplicate of #14 and should be closed.