Fix critical error when space in bin path

[marob]

The bin-version-check module delegates version extraction to the bin-version module: https://github.com/sindresorhus/bin-version-check/blob/master/index.js#L16

The bin-version module extracts the bin version with childProcess.exec(bin + ' --version', ...): https://github.com/sindresorhus/bin-version/blob/master/index.js#L6

childProcess.exec expects its first argument to be "The command to run, with space-separated arguments": https://nodejs.org/api/child_process.html#child_process_child_process_exec_command_options_callback

Consequently, before my fix, if a space is present in the path to the bin, everything after the first space is interpreted as arguments. And the bin correspond to the first part of the path (before the first space), which is NOT ok.

[shinnn]

@marob Can you submit this PR to https://github.com/sindresorhus/bin-version/pulls instead? I think that's more proper way to fix this problem.

cc: @sindresorhus

[marob]

Here is the corresponding PR: https://github.com/sindresorhus/bin-version/pull/6

I'm not convinced it should be fixed in bin-version, but I'll let you and @sindresorhus decide.

[shinnn]

@marob Thanks.

[sindresorhus]

Yeah, should be fixed in bin-version. Never thought of the use-case that someone would supply an absolute path.

[marob]

OK, I've updated my PR on bin-version to try not to break any module while fixing the issue. Meanwhile, I'm keeping this PR (on bin-wrapper) if fixing the issue in bin-version proves to be impossible.

[sindresorhus]

This was fixed in bin-version.