kevva / bin-wrapper

Binary wrapper that makes your programs seamlessly available as local dependencies
MIT License
152 stars 65 forks source link

Should not make assumptions based on process architecture #48

Open Daniel15 opened 8 years ago

Daniel15 commented 8 years ago

If I'm using a 32-bit version of Node on a 64-bit version of Windows, and only configure a win32 x64 binary using bin-wrapper, it throws the following error:

No binary found matching your system. It's probably not supported.

This is misleading, as there is a binary matching my system. The real error is something like "No binary found matching the architecture of your Node.js process", as it's not even checking the system architecture. The only time it should care about the architecture of the Node.js process is if you want to load something into that process itself (for example, a DLL file).

See https://github.com/facebook/flow/issues/2288