search

kevva / bin-wrapper

Binary wrapper that makes your programs seamlessly available as local dependencies
MIT License
152 stars 66 forks source link

Update to download 7.1.0 #65

Closed rejas closed 6 years ago

rejas commented 6 years ago

Switched to the new promise based API of download, updated dependencies and node versions Picking PR up from https://github.com/kevva/bin-wrapper/pull/57

rinella commented 6 years ago

nice! i see where I was going wrong now.

rejas commented 6 years ago

hopefully @kevva picks it up soon :-)

XhmikosR commented 6 years ago

/CC @sindresorhus

XhmikosR commented 6 years ago

@sindresorhus: thanks! Can you cut a new release too?

sindresorhus commented 6 years ago

@XhmikosR https://github.com/kevva/bin-wrapper/pull/60#issuecomment-404142576 needs to be done first. // @realityking

rejas commented 6 years ago

@sindresorhus what has to be done there in #60 that isnt already donehere? download is updated and the code is adapted to its new promise api.

realityking commented 6 years ago

@sindresorhus I think this is fine to merge. I‘ll do the PR for the external Promise API.

realityking commented 6 years ago

Sorry misread the comment - I‘ll work on the API PR later today!