kevva / bin-wrapper

Binary wrapper that makes your programs seamlessly available as local dependencies
MIT License
152 stars 65 forks source link

Update `download` dependency and require Node.js 10 #77

Open tjbulick opened 4 years ago

tjbulick commented 4 years ago

Update dependency package called download in order to pull in security patch. This also increases required node.js version to 10

tjbulick commented 4 years ago

Resolves #76

apfelbox commented 4 years ago

The CI failures seem unrelated to this PR

danychi commented 3 years ago

Could you check this MR @kevva? 😊

tjbulick commented 3 years ago

By the way, i also checked that CI errors don't relate to my changes. But maybe repository maintainer would say that we need to fix them.

Anyway, i'm still here and ready to fix them, but it would be nice to hear something from the maintainer. Maybe he will just merge these changes despite CI errors, at least because in past versions he already did so.

XhmikosR commented 3 years ago

BTW it'd be nice to switch to GitHub Actions. Also, check if pify is really needed and if we could just use util.promisify