kevva / decompress

Extracting archives made easy
MIT License
415 stars 51 forks source link

Vulnerable to Infinite Loop via malformed MKV file through `file-type` package #100

Open qooban opened 2 years ago

qooban commented 2 years ago

The following report is provided by NPM audit when using the latest version of decompress package (v4.2.1):

file-type  <16.5.4
Severity: moderate
file-type vulnerable to Infinite Loop via malformed MKV file - https://github.com/advisories/GHSA-mhxj-85r3-2x55

node_modules/decompress-tar/node_modules/file-type
node_modules/decompress-tarbz2/node_modules/file-type
node_modules/decompress-targz/node_modules/file-type
node_modules/decompress-unzip/node_modules/file-type
  decompress-tar  >=4.0.0

  Depends on vulnerable versions of file-type
  node_modules/decompress-tar
  decompress-tarbz2  >=4.0.0

  Depends on vulnerable versions of file-type
  node_modules/decompress-tarbz2
    decompress  >=4.0.0
    Depends on vulnerable versions of decompress-tarbz2
    node_modules/decompress

  decompress-targz  >=4.0.0
  Depends on vulnerable versions of file-type
  node_modules/decompress-targz

  decompress-unzip  >=4.0.1
  Depends on vulnerable versions of file-type
  node_modules/decompress-unzip

More description about the problem is provided here: https://github.com/advisories/GHSA-mhxj-85r3-2x55

The fix was implemented in file-type v16.5.4, so probably file-type should just be bumped in sub-packages: decompress-tar, decompress-tarbz2, decompress-targz, decompress-unzip.

alfaproject commented 2 years ago

@sindresorhus any chance you could give some security love to this package? <3

UdayKumarNettem commented 1 year ago

@sindresorhus @kevva : When can we expect the file-type vulnerability fix?

https://github.com/advisories/GHSA-mhxj-85r3-2x55.

https://nvd.nist.gov/vuln/detail/CVE-2022-36313

sonarqube-scanner@2.8.2 └─┬ decompress@4.2.1 └─┬ decompress-unzip@4.0.1 └── file-type@3.9.0

UdayKumarNettem commented 1 year ago

@qooban @alfaproject : How do you resolve this issue?

qooban commented 1 year ago

@UdayKumarNettem I don't have a solution for that. I provided my findings in the issue description.