search

kevva / download

Download and extract files
MIT License
1.28k stars 200 forks source link

Fix weirdness from using an older version of decompress #137

Closed liath closed 6 years ago

liath commented 7 years ago

For some reason decompress@4.0.0 would occasionally give me an empty array instead of the contents of a tgz I had asked download to fetch and extract. Updating resolves this.

liath commented 7 years ago

FYI - This issue showed up for me in node-jq which is using bin-build to download and compile jq.

simonepri commented 7 years ago

👍

jdalton commented 7 years ago

I'm seeing an issue where on Windows folders and files are created but files are all 0 bytes. Related to https://github.com/flipxfx/download-git-repo/issues/21.

liath commented 7 years ago

@jdalton I can't reproduce that on Windows 10 with node@8.2.1. Can you provide steps and env stuff?

jdalton commented 7 years ago

It turned out this was due to a silent promise fail unrelated to download.

liath commented 7 years ago

Anything I can do for this PR? It's been sitting for a long minute.

silverwind commented 6 years ago

That dependency was upgraded in https://github.com/kevva/download/commit/0bf3da15e4d4c7a96bf1e60d51a40f4ad1b321a6.

liath commented 6 years ago

Sweet, thanks for clearing this. :)