kevva / download

Download and extract files
MIT License
1.28k stars 200 forks source link

Remove gulp-util #150

Closed ghost closed 6 years ago

ghost commented 6 years ago

I'm using your plugin in a personal project. But it have some warnings with gulp-util. Can you follow this recomendations to remove that?

gutil.File => https://www.npmjs.com/package/vinyl gutil.replaceExtension => The .extname property on Vinyl objects or https://www.npmjs.com/package/replace-ext gutil.colors => https://www.npmjs.com/package/ansi-colors gutil.date => https://www.npmjs.com/package/date-format gutil.log => https://www.npmjs.com/package/fancy-log gutil.template => https://www.npmjs.com/package/lodash.template gutil.env => https://www.npmjs.com/package/minimist gutil.beep => https://www.npmjs.com/package/beeper gutil.noop => https://www.npmjs.com/package/through2 gutil.isStream => Use the .isStream() method on Vinyl objects gutil.isBuffer => Use the .isBuffer() method on Vinyl objects gutil.isNull => Use the .isNull() method on Vinyl objects gutil.linefeed => Use the string '\n' in your code gutil.combine => https://www.npmjs.com/package/multipipe gutil.buffer => https://www.npmjs.com/package/list-stream gutil.PluginError => https://www.npmjs.com/package/plugin-error

DvStephen commented 6 years ago

@andresjim this package hasn't used this gulp-util dependency for a long time, so you should look at whatever package is using an older version of this.

michaeljota commented 6 years ago

@DvStephen The package that use gulp-util is other package of this same author. I came here to see if this module can stop using the module using gutil, but I guess it can't.

DanielRuf commented 6 years ago

It is already removed since a few releases. https://github.com/kevva/download/commit/49d6bcbbfb2c784397b72ab7bda820079aeebf15#diff-b9cfc7f2cdf78a7f4b91a753d10865a2

michaeljota commented 6 years ago

As I said, not this particular package, but one from the same author.

DanielRuf commented 6 years ago

The answer was meant for other readers and commenters ;-)

michaeljota commented 6 years ago

Oh! Sorry. :p

silverwind commented 6 years ago

Please upgrade your version of download.