kevva / download

Download and extract files
MIT License
1.28k stars 200 forks source link

is_url_superb prevents downloading from intranet domains #50

Closed chris-t-reilly closed 9 years ago

chris-t-reilly commented 9 years ago

The is_url_superb package throws an error when dealing with domains defined on the local intranet (example .local domains). Can I suggest/contribute a validateURL option?

sindresorhus commented 9 years ago

Exposing that would be leaky abstraction.

@kevva I see no reason for doing such a strict check on the input. Maybe add a loose mode option in is-url-superb that download could use which allowed any kind of domain?

chris-t-reilly commented 9 years ago

Yes, that's much better API-wise.

kevva commented 9 years ago

Would probably need to add it in url-regex first.