search

kevva / github-repositories

Get all GitHub repos from a user or an organization
MIT License
37 stars 11 forks source link

add hightlight forks #4

Closed saromanov closed 9 years ago

saromanov commented 9 years ago

Hi! I've just added highlight forks, when it call from command line

github-repositories username -f

or

github-repositories username --hl-forks

After that, all links to forked repositories will be shown with different color (i choose chalk.bold.blue)

sindresorhus commented 9 years ago

Sounds useful, but I don't see the point of having it behind an option. It could just be the default.

saromanov commented 9 years ago

@sindresorhus If this will be by default, it need to provide additional note, that colored links is forks. So, it seems to me, that easiest way, just to give this feature by option.

sindresorhus commented 9 years ago

"an option" seems to always be the easiest way, but most often not the best. Might be other ways than color to mark something as a fork. Just throwing it out there.

saromanov commented 9 years ago

So, no need options, just set it by default?

kevva commented 9 years ago

@sindresorhus, what color would fit here? Dunno if I want to highlight forks more than regular repos, rather dim them.

sindresorhus commented 9 years ago

Might be other ways than color to mark something as a fork.

Either chalk.dim() or Foo (fork) (with the parens part dimmed).

kevva commented 9 years ago

Alright, I think I'll go with name (fork). Feel free to disagree and change it though ;P.