search

kevva / github-repositories

Get all GitHub repos from a user or an organization
MIT License
37 stars 11 forks source link

Added object type to options #9

Closed RichardLitt closed 7 years ago

RichardLitt commented 7 years ago

Not realizing that token needed to be in an {token: 'string} form threw me. This should help.

SamVerschueren commented 7 years ago

As @kevva has other priorities at the moment I have to decide that I'm going to pass on this. This is how we document all of our APIs.

RichardLitt commented 7 years ago

Fair enough. It might be worth actually going through and updating your other APIs, though, as the current setup can be confusing. Granted, I have no idea how many APIs you have.

SamVerschueren commented 7 years ago

It's not only me though, it's also @kevva and @sindresorhus who do it in the exact same way. So yes, it's quite a lot of repositories ;). I never saw someone complaining about the current structure. We experimented with a TypeScript/Flow like approach with type information but until now, we still do it this way.

RichardLitt commented 7 years ago

Cool. Alright! No worries then.