search

kevva / screenshot-stream

Capture screenshot of a website and return it as a stream
MIT License
236 stars 38 forks source link

Handle redirects #14

Closed kevva closed 8 years ago

kevva commented 9 years ago

Something like https://github.com/ariya/phantomjs/issues/10389#issuecomment-31947910.

maboiteaspam commented 8 years ago

It should wait for newer phantomjs given that last comment https://github.com/ariya/phantomjs/issues/10389#issuecomment-158962088

wait for 2.1, given that release log http://phantomjs.org/release-2.0.html

Note 1: PhantomJS 2.0 is the first release in the 2.x. It has several regressions compared to the previous 1.9 release.
sindresorhus commented 8 years ago

We're upgraded to PhantomJS 2.1. So this should now be possible. PR welcome :)

kevva commented 8 years ago

Apparently, PhantomJS handles redirects by default now judging from the test.