Replace PhantomJS with Puppeteer

[kevva]

Probably still needs some work:

• [ ] Make sure we handle errors
• [x] Add script option
• [ ] Add style option
• [ ] Add some sort of hook that exposes page from puppeteer to users
• [ ] Add keepAlive option with a .close method on the returned promise that lets users kill it manually (good when capturing many pages).
• [ ] Code improvements?

[sindresorhus]

@kevva What do you think about targeting Node.js 8? So we can use async/await. Would be so much nicer. It's going to be a major release anyway. I plan to do that in the next major of Pageres.

[kevva]

@kevva What do you think about targeting Node.js 8? So we can use async/await. Would be so much nicer. It's going to be a major release anyway. I plan to do that in the next major of Pageres.

👍 I agree. And it would be pretty future proof for a foreseeable future.

[sindresorhus]

I'm super excited we can finally get rid of PhantomJS! 🙌

[kevva]

Now uses async/await. Some tests are still failing though.

[SamVerschueren]

By the way, should we consider renaming this to screenshot instead of screenshot-stream, it's not a stream anymore :p.

[kevva]

By the way, should we consider renaming this to screenshot instead of screenshot-stream, it's not a stream anymore :p.

If we can get the name, yes. But it hasn't been updated in five years so shouldn't be impossible.

[SamVerschueren]

Added a PR to Puppeteer to make injecting js and css much easier. https://github.com/GoogleChrome/puppeteer/pull/996

[sindresorhus]

What's left to do here?

[kevva]

Probably some small things to edge out. I'll take a look in the weekend.

[c0bra]

Any news on this? I'd rather not have to fork to get around some PhantomJS wonkiness.

[cluk3]

I can help with this if needed!

[sindresorhus]

@cluk3 Help is most welcome. Open a PR based on this one. I'll review ;)