search

kevva / to-ico

Convert PNG to ICO in memory
MIT License
137 stars 19 forks source link

Update resize-img@2.0.0 #19

Closed thisconnect closed 2 months ago

pft commented 4 years ago

The checks fail because the use of async functions and the NodeJS versions targeted by travis.yml (4 and 6). Async functions are available without flags from NodeJS version 8 onwards.

thisconnect commented 4 years ago

The checks fail because the use of async functions and the NodeJS versions targeted by travis.yml (4 and 6). Async functions are available without flags from NodeJS version 8 onwards.

yes and therefore I'd love your PR https://github.com/kevva/to-ico/pull/23 :)

Tofandel commented 3 years ago

@kevva A deps update is long overdue, getting tons of deprecation warning on install, please :pray:

ebonow commented 3 years ago

Please escalate this. Currently, to-ico is a dependency of favicons and all of its users (including myself) are failing security audits

Screen Shot 2021-04-24 at 11 56 08 AM
chevEldrid commented 2 years ago

just ran into the same issue with url-regex that led me here, seems to be becoming an increasingly large problem

DavidHalman commented 2 years ago

Also ran into this issue, I would love a fix soon!

NJAldwin commented 2 years ago

For anyone else finding this issue causing audit failures: you can update to png-to-ico, which seems to be a drop-in replacement for to-ico without this vulnerability.

This is what favicons has done: https://github.com/itgalaxy/favicons/pull/337