Update feature no longer works

[kewalsk]

The problem is that now the "update" feature no longer works, I activate the checkbox but nothing happens.

In My-OpenPeriscope when you enable the "Enable notifications" option the "repeat" button appears on the side of the transmissions. When you activate it, it automatically requests the "Get stream link" automatically in the same time interval as the "Notification refresh interval" setting, so if the transmission is deleted, you will always have the most recent partial replay available. But now it is not working anymore, I believe the function broke with the changes in your "Fix notifications" commit

I believe I didn't touch the existing functionality so the links should work as you described in them. Can you check and confirm which button gives the proper link now (if any)?

I did not understand your question. The "Get stream link" button still works perfectly, the problem is that the "repeat" checkbox to automate the action of getting these (updated) links (even with the browser in the background) is no longer working. One thing I noticed is that before, when I opened My-OpenPeriscope (the original of gitnew2018) and opened the "Following2" tab, all the available replays automatically showed they download links, but now no more, I believe that the two problems are related.

[kewalsk]

Added checkbox to activate auto getting partial replay links(drkchange22)

This change is not working?

[kewalsk]

It was not clear but after tests I can see several separate problems:

1. There is no repeat checkbox at all in userscript version (however it is shown in standalone app)
2. When repeat checkbox is on then after the first notification the red buttons disappear - this bug is also in the original version but happen occasionally,
3. After broadcast ends the ffmpeg button disappear:
4. Sometimes, this button disappear also for broadcasts still running:
5. There is error on console log (already fixed in devel branch)

[KaMyKaSii]

It was not clear but after tests I can see several separate problems:

1. There is no update checkbox at all in userscript version (however it is shown in standalone app)
2. When update checkbox is on then after the first notification the red buttons disappear - this bug is also in the original version but happen occasionally,
3. After broadcast ends the ffmpeg button disappear:
4. Sometimes, this button disappear also for broadcasts still running:
5. There is error on console log (already fixed in devel branch)

There is a "repeat" checkbox in the userscript version, which I usually use, just be sure to also enable the "Enable notifications" setting and use the "Save" button in the page footer. And thanks for correcting it on devel branch. Do you think it is possible to make the ffmpeg button also appear when using the repeat function? And about the red buttons not showing up when using the repeat function, I think it's "normal". After all the red links (still in live) are static, so do not change, just the replay links that change. And you could configure so that the output in the ffmpeg of live streams start with "L_" or something similar at the beginning of the file? I ask you to do this so that there is no danger that the file will be overwritten when both m3u8 live (from public lives) and m3u8 partial replay are downloaded in the same folder.

[kewalsk]

There is a "repeat" checkbox in the userscript version

Sometimes yes sometimes no. I suppose there is a bug in settings management. As you say this can be fixed by saving settings. Be sure also to click on all checkboxes because otherwise they will be not initialized. Doing so will fill up settings with values and remain until logout. Strange is that this behaves different way on standalone application which is much easier to test.

Do you think it is possible to make the ffmpeg button also appear when using the repeat function?

I think so, but the logic here is very strange. I'm trying to understand it.

And about the red buttons not showing up when using the repeat function, I think it's "normal". After all the red links (still in live) are static, so do not change, just the replay links that change.

Yes but the buttons are deleted. It would be OK for replays but not for running broadcasts.

And you could configure so that the output in the ffmpeg of live streams start with "L_" or something similar at the beginning of the file? I ask you to do this so that there is no danger that the file will be overwritten when both m3u8 live (from public lives) and m3u8 partial replay are downloaded in the same folder.

OK, no problem. I was sure the replays has different names (with PR_ or R__). The filenames, however, are not so good in my opinion. I'm using completely different naming and separate folders. I could add it as an option but after solving the problem with settings.

[KaMyKaSii]

Sometimes yes sometimes no. I suppose there is a bug in settings management. As you say this can be fixed by saving settings. Be sure also to click on all checkboxes because otherwise they will be not initialized. Doing so will fill up settings with values and remain until logout. Strange is that this behaves different way on standalone application which is much easier to test. The filenames, however, are not so good in my opinion. I'm using completely different naming and separate folders. I could add it as an option but after solving the problem with settings.

From what I realized the problem with the settings is not the need to activate all the checkboxes but the checkboxes that come active by default. For example, the "Enable notifications" checkbox (the one required for the repeat function to appear) is enabled by default, but the repeat function does not work by default. It is necessary to disable the checkbox, activate again and then save, just so it will work, at least in the userscript version. I hope this information is helpful for you to find a solution

I think so, but the logic here is very strange. I'm trying to understand it.

I saw you got it on devel branch, thanks!

Yes but the buttons are deleted. It would be OK for replays but not for running broadcasts.

You're right, keeping the red buttons is essential

OK, no problem. I was sure the replays has different names (with PR_ or R__).

I think you're right and I got confused about it, sorry

And I was thinking of another FFMPEG button: one that first downloaded m3u8 live, then the m3u8 from partial replay and then concat partial replay + live at once (this would be very useful for lives that will not have full replay at the end and the user could not generate or could not access some partial replay at the end). Do you think it's possible to do this in a single command in ffmpeg?

[kewalsk]

And I was thinking of another FFMPEG button

Sounds interesting, I have to try it. Please make a separate issue about it.

[KaMyKaSii]

And I was thinking of another FFMPEG button

Sounds interesting, I have to try it. Please make a separate issue about it.

Done. I think you can close this issue now that it has already been fixed