kewisch / quickmove-extension

Quick Folder Move Add-on for Thunderbird
85 stars 26 forks source link

Update on this closed issue: pop-up does not show - the issue is still there but I've narrowed it down a bit: #146

Open afmoene opened 5 months ago

afmoene commented 5 months ago

Update on this closed issue: the issue is still there but I've narrowed it down a bit:

The issue (popup not showing) only occurs when I have the Compact Headers extension enabled (https://addons.thunderbird.net/en-US/thunderbird/addon/compact-headers/) More specifically:

I have no programming experience with Thunderbird extensions, so I have no idea how the two would interact. Nor, which of the two extensions would be the cause of this unintended interaction. Hence, I do not know wha twould be the way forward.

PS: I'm the same person as that opened the original issue (afmoene), I'm just inconsistent with the github account that I use for different tasks.

Originally posted by @scientific-method-course in https://github.com/kewisch/quickmove-extension/issues/138#issuecomment-2016739754

ernstki commented 2 weeks ago

Pretty sure you nailed it here. Thanks for the big hint.

I hide as many user interface elements as I possibly can, relying heavily on Compact Headers since recent Thunderbird updates took away the ability to customize the message pane's toolbar.

Some observations:

Animated GIF demonstrating the behavior of Shift+G shortcut, which opens the UI attached to the top application toolbar (to the right of the search bar), then the Shift+Y shortcut, which opens the UI attached to the message pane, next to the buttons for 'Forward,' 'Archive,' 'Junk,' and so on

If both buttons are hidden, either through Thunderbird's built-in customization or the Compact Headers extension, there's no UI to show when you press the shortcuts, so the shortcut behavior just appears broken.

There probably isn't much that @kewisch can do to fix this, short of:

But at least I know that these two extensions are—for now—an either-or deal.

scientific-method-course commented 2 weeks ago

Many thanks for this clarification and a view behind the scenes (including all your links).

Given that a simple solution is not around the corner, I will try to find out how work around this situation. As a programmer myself I recognized that one can make certain design choices that turn out to be sub-optimal at a much later stage (but would required a large redesign to solve).

kewisch commented 2 weeks ago

I am certainly limited by what the Thunderbird WebExtensions API allows me to do. I don't want to go back to custom UX. My extension tries to use the message header bar first it that is visible, and if not then the main popup.

Maybe there are ways for compact headers to keep the surface available for extensions?

ernstki commented 1 week ago

I am certainly limited by what the Thunderbird WebExtensions API allows me to do. I don't want to go back to custom UX.

Thanks for chiming in, @kewisch. Agreed on all counts, and not having had to contend with either API or UI design for Thuderbird extensions myself, obviously I respect your position. But solely as a user, part of me remains wistful about what the old XUL-based extensions were capable of, relative to the modern API. I understand those were simpler times, though.

My extension tries to use the message header bar first it that is visible, and if not then the main popup.

Unless it's some weirdness particular to my installation, the latest Quick Folder Move (with no other extensions active) uses the main popup for "Go To," but the message header bar for the others. Different behavior, even when both buttons are visible, as seen in the GIF above.

kewisch commented 1 week ago

Ah yes indeed, I remember I intentionally went with the main toolbar first for goto. It makes sense though: going to a folder is not an action on the message, so it doesn't make sense to open the message header toolbar button. It will fall back to that one if the main toolbar isn't available.

RealRaven2000 commented 1 week ago

Ah yes indeed, I remember I intentionally went with the main toolbar first for goto. It makes sense though: going to a folder is not an action on the message, so it doesn't make sense to open the message header toolbar button. It will fall back to that one if the main toolbar isn't available.

Another reason for avoiding this is that (at least in classic folder views, where the header bar is in the center) this actually limits the length of the search dropdown, so it is actually better to locate it up top.

kewisch commented 3 days ago

@afmoene Is there anything specific I can do on this issue? I'm not 100% sure what the problem is, and if it is any different from #158