search

kewisch / quickmove-extension

Quick Folder Move Add-on for Thunderbird
84 stars 26 forks source link

Inconsistent Undo Behaviour #16

Open bbceg opened 4 years ago

bbceg commented 4 years ago

Version: 2.0.0pre1 Thunderbird: 68.3.0 OS: Windows 10

Steps to reproduce:

  1. Move an email to a folder
  2. Undo the action

Expected result: Email reappears

Actual result: Performs the last "non-quickmove" action (e.g. restoring a deleted email)

bbceg commented 2 years ago

Not sure if this issue can be closed but perhaps worth noting that Undo works fine on v1.10.0 (as I found out to my delight just now!).

kewisch commented 1 year ago

Unfortunately this is broken again due to the rewrite. The new APIs don't have support for the undo/redo manager. See https://bugzilla.mozilla.org/show_bug.cgi?id=1671042 for details. I also don't see an easy way to do this with an internal API.

bbceg commented 1 year ago

Still seems to be working for me on v1.10 on Thunderbird 102.14.0, or does this only apply to v2?

kewisch commented 1 year ago

Yes, applies only to v2. I've started using the new WebExtensions/MailExtensions technology here, and those don't support the undo/redo stack at current.

bbceg commented 1 year ago

Okay, thanks for confirming and, as ever, your efforts with the add-on. Not sure when it makes to make the switch to v2, 1.10 is working well but presumably has a shelf life.

kewisch commented 1 year ago

Once you upgrade to Thunderbird 115, you'll necessarily be updated to v2. 115 is already out, so just a matter of when automatic updates are pushed out to everyone, or your distro doing the update.

bbceg commented 1 year ago

Rats, I was afraid you might say that! Hopefully the undo/redo manager will gain support in the not too distant future.

ThomGr commented 8 months ago

I understand the difficulty to implement a full undo mechanism, but this is very often causing an issue. If for whatever reason you accidentally move an email to the wrong folder (I have lots of those), and you do not remember a detail of the email, there is no realistic way to find it again (unless you know e.g. the date it was received, the sender etc.). So two suggestions:

  1. can you implement a simple "undo the last action", so the extension itself remembers the last move (and only one, not the stack) and undoes is without attaching to the general undo mechanism. This would of course require a separate shortcut
  2. alternatively, can you display the last move (subject and target folder) so there is a chance to find the last email moved, or implement a "go to" for that last email?