search

kewisch / sepa.js

Create and validate SEPA XML transactions
http://kewisch.github.io/sepa.js
Other
88 stars 61 forks source link

Fix "null" in Ctry, Street and address #64

Closed FreedomNX closed 10 months ago

FreedomNX commented 11 months ago

Fix error "null" in Ctry, Street and Address for Credit.

lippertto commented 11 months ago

Hi @FreedomNX , do you think you can add a test to fix that the behavior for the future? There are already some examples with XPath expressions which you can adapt to your needs.

FreedomNX commented 11 months ago

I did.

kewisch commented 11 months ago

@lippertto Thanks for taking an initial look! Would you like to go ahead and complete the review?

lippertto commented 11 months ago

@kewisch , the PR looks good for me. Can you run the pipeline and merge the branch?

lippertto commented 11 months ago

@kewisch - any thoughts on the PR? 😃

lippertto commented 10 months ago

Friendly reminder @kewisch

kewisch commented 10 months ago

Thanks for the review, much appreciated! I've been off the past week, apologies for the delay.