search

kewlbear / YoutubeDL-iOS

Swift package of youtube_dl python module for iOS
MIT License
112 stars 35 forks source link

Using yt-dlp instead of Youtube-dl #2

Closed sherwinzadeh closed 2 years ago

sherwinzadeh commented 2 years ago

First of all, @kewlbear, thank you for this great tool.

Recently there's been an issue on Youtube-dl where some videos are taking a very long time to download. See: https://github.com/ytdl-org/youtube-dl/issues/29326

Users have said that the ytl-dlp fork solves it and I'd like to try it out in YoutubeDL-iOS. What I've done is change: public static let latestDownloadURL = URL(string: "https://github.com/yt-dlp/yt-dlp/releases/latest")! I also changed the file name stored locally from youtube_dl to yt-dlp The problem I'm getting though is Python.attemptImport("yt-dlp") throws an exception: No module named 'yt-dlp' (I've tried many other names too)

You can see my attempts in this fork in the yt-dlp branch.

Any idea what I'm doing wrong?

kewlbear commented 2 years ago

Updated to use yt-dlp. Thanks for your info!

sherwinzadeh commented 2 years ago

I believe you need to turn off bitcode in order for Python modules to work.

On Dec 28, 2021, at 8:03 AM, Khatri Jigar @.***> wrote:

 Hello @kewlbear.

Thank you for this great tool.

I have one issue the tools are working fine when I test in debug mode. but when I upload build in TestFlight and check the app is crash in downloadPythonModule or YoutubeDL()

can you please let me know this is working this tool in live TestFlight. no nee to upload the app in App Store.

Any idea what I'm doing wrong?

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.

khatri6168 commented 2 years ago

Hello @sherwinzadeh Thank you for replay.

I have off bitcode and upload agin new build bit still it'e crashing not working this in only in TestFlight.

Have you face this type of issue?

HamstyDeveloper commented 5 months ago

we have an issue. the build is working in simulator but not working on real device