search

kewlfft / ansible-aur

Ansible module to manage packages from the AUR
GNU General Public License v3.0
299 stars 47 forks source link

Feature: aur repo only option when upgrading whole system closes #2 #17

Closed visibilityspots closed 6 years ago

visibilityspots commented 6 years ago

I gave it a try to implement a feature where the module will only use the AUR repository using the --aur option when a parameter aur_repo_only is setted to true.

The option will only be enabled on the aurman pacaur and trizen helpers when the parameter aur_repo_only is setted to true.

Don't hesitate to give feedback about the implementation!

kewlfft commented 6 years ago

Thanks I will review it, I thought we could find a simpler implementation, I would avoid importing re for something that straightforward. Also note that "aur_repo" is a pleonasm.

kewlfft commented 6 years ago

Have a look at my implementation and let me know please

visibilityspots commented 6 years ago

your implementation does look indeed a bit simpler as you mentioned before, I will close mine. Maybe add to the documentation of the aur_only param that it's only used for upgrade and defaults to no?

kewlfft commented 6 years ago

yes will do it when I have a chance or feel free to improve the doc. thanks