search

key-networks / ztncui

ZeroTier network controller UI
GNU General Public License v3.0
1.53k stars 228 forks source link

Improvement: member filtering #58

Open Jarusss opened 3 years ago

Jarusss commented 3 years ago

Hi, as there is no sorting, I modified members.pug to provide filtering of members. Maybe it would be useful to add this to master?

members.txt

key-networks commented 3 years ago

Thanks for your contribution, @Jarusss. I have not tested your change, but it looks like it would be a useful addition. However, this PR https://github.com/key-networks/ztncui/pull/57 will soon be merged into master and in the process, members.pug will be deleted and replaced with network_detail.pug. Do you want to wait for for https://github.com/key-networks/ztncui/pull/57 to be merged into master and then submit a PR for your change?

key-networks commented 3 years ago

@Jarusss, PR 57 has been merged into master. Do you want to create a PR for your suggested changes?

Jarusss commented 3 years ago

I'm sorry key-networks,

What is PR? I'm happy that my suggestion is useful, as this is great project.

Jaromir Chartliński mobilnie...

pon., 1 mar 2021, 08:18 użytkownik key-networks notifications@github.com napisał:

@Jarusss https://github.com/Jarusss, PR 57 has been merged into master. Do you want to create a PR for your suggested changes?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/key-networks/ztncui/issues/58#issuecomment-787714177, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKR6LSUQ3QELDBNMGEOH5GLTBM5SRANCNFSM4YETJQCQ .

key-networks commented 3 years ago

That's a pull request https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/about-pull-requests