key-networks / ztncui

ZeroTier network controller UI
GNU General Public License v3.0
1.51k stars 227 forks source link

Fix "RELAY" status not showing #82

Open lideming opened 2 years ago

lideming commented 2 years ago

Related: #69

key-networks commented 2 years ago

Thanks @lideming for submitting this fix. I have included it in the following DEB and RPM builds for your testing, along with an upgrade of jquery from 3.4.1 to 3.6.0 (just so that you aware that any changes may be due to the change in jquery). Could you please test this build and let us know if it is ok? DEB: https://key-networks.s3.us-west-1.amazonaws.com/deb/ztncui/1/x86_64/ztncui_0.8.7_amd64.deb

RPM: sudo dnf --enablerepo=ztncui-testing upgrade ztncui

sanbrother commented 2 years ago

I did some test. Is it correct to show "ONLINE" when all ZeroTier networks are disconnected? I should be behind some NAT, and have no public IPs. The "Peer Address" (175.166.187.XXX) is a dynamic IP allocated by ISP. Should the "Peer Address" display ZeroTier networks IP? (Like 192.168.xxx.yyy)

lideming commented 2 years ago

I did some test. Is it correct to show "ONLINE" when all ZeroTier networks are disconnected? I should be behind some NAT, and have no public IPs. The "Peer Address" (175.166.187.XXX) is a dynamic IP allocated by ISP. Should the "Peer Address" display ZeroTier networks IP? (Like 192.168.xxx.yyy)

I know it can be confusing but it's correct. The "peer status" is "ONLINE" when the client established peer connection to the controller. It's the same thing as shown by running the command zerotier-cli peers on the controller.

sanbrother commented 2 years ago

Not sure why, it doesn't work today. All peers are 'OFFLINE', but can ping each other. ZeroTier's official console, has a 'Last seen' column, it shows either 'ONLINE' or the time since last online state. Can we archive that ?