key4hep / CLDConfig

Apache License 2.0
0 stars 10 forks source link

ConformalTracking: increase MaxDistance from 0.03 to 0.05 so that for… #19

Closed andresailer closed 9 months ago

andresailer commented 10 months ago

… CLD_o2_v05 we can extrapolate from the first layer to the second layer

@Zehvogel How should we version this?

BEGINRELEASENOTES

ENDRELEASENOTES

D0 residuals with 0.03 (10K 10GeV Muons at 89Degrees) Conformal

D0 residuals with 0.05 (10K 10GeV Muons at 89Degrees) Conformal005

TruthTracking Result Truth

Zehvogel commented 10 months ago

Thx for solving this mystery!

Regarding versioning I am not so sure what to do... at some point when someone is using CLDConfig to make any kind of production we should make a tag (if that someone actually tells us about it).

If this does not negatively impact the performance for the o1 model we should just merge it without caring about attaching some kind of version to this. Not so easy to say though without a big list of validation tests :D

But first of all lets wait for @gaswk to report.

gaswk commented 10 months ago

Thank you for identifying the issue.
Below, you'll find a comparison for the D0 resolution with ConformalTracking MaxDistance increase from 0.03 to 0.05 for FCCee_o1_v04, where open markers represent ConformalTracking MaxDistance = 0.03: CF005_o104

and here with D0 resolution for CLD_o2_v05: CF005

andresailer commented 9 months ago

Very good! Thanks!

There is a little bit of deterioration for FCCee_o1_v04. So should we have a switch for the value between the different detector models?

Zehvogel commented 9 months ago

A switch sounds like a good idea but do we want it to be manual or automatic based on which geometry is used?