search

key4hep / EDM4hep

Generic event data model for HEP collider experiments
https://cern.ch/edm4hep
Apache License 2.0
25 stars 35 forks source link

Adding metadata name for event filter statistics #283

Closed kjvbrt closed 3 months ago

kjvbrt commented 7 months ago

The vector<int> contains three values: Seen, accepted and targeted.

BEGINRELEASENOTES

ENDRELEASENOTES

jmcarcell commented 7 months ago

Which filters does this apply to? And what does targeted mean? The ones for which the filter can apply?

kjvbrt commented 7 months ago

This is for filters which filter events e. g. : GenEventFilter.

The targeted number of events is number of events specified in the steering or k4run -n. If someone is reading files from a input file, there might not be enough events in the file to fulfil it. Ideally targeted and accepted should be equal.

tmadlener commented 7 months ago

What about cases where there are multiple filters? Should there be the possibility to add a filter name?

kjvbrt commented 6 months ago

What about cases where there are multiple filters? Should there be the possibility to add a filter name?

Than this needs to be a vector of some struct/class (consisting of three numbers and a name for the filter)?

jmcarcell commented 6 months ago

I think having the name is fine but we can keep discussing how it's used. Also, why is the number of events requested important? How is that information going to be used? Is it useless when you request more events than available (it only tells you that there weren't enough events)

jmcarcell commented 4 months ago

@kjvbrt any answers to my last comment? Do we want the comment to be quite restrictive? Does one always need the number of events? Maybe we should just remove the comment entirely like the other constants?

kjvbrt commented 3 months ago

My goal was to standardize also vector members, but that is probably too restrictive.