search

key4hep / EDM4hep

Generic event data model for HEP collider experiments
https://cern.ch/edm4hep
Apache License 2.0
25 stars 35 forks source link

`RawCalorimeterHit` is not connected to the rest of EDM4hep #317

Closed tmadlener closed 3 months ago

tmadlener commented 3 months ago

RawCalorimeterHit is not referenced in any relation of any datatype in EDM4hep. Hence, it is effectively unconnected to the rest of EDM4hep. This is similar to the situation with RawTimeSeries (see https://github.com/key4hep/EDM4hep/issues/316). The definition of the RawCalorimeterHit is

https://github.com/key4hep/EDM4hep/blob/bd9f45039149781a9c54799a6d03df56b1b5ed49/edm4hep.yaml#L395-L401

The datatype that probably has the closest resemblance with the RawCalorimeterHit is the CalorimeterHit, defined as https://github.com/key4hep/EDM4hep/blob/bd9f45039149781a9c54799a6d03df56b1b5ed49/edm4hep.yaml#L404-L413

Historically, the RawCalorimeterHit is present because it's also present in LCIO and the fact that the CalorimeterHit has an untyped getRawHit in LCIO where it could in principle be attached. However, this mechanism doesn't exist in EDM4hep.

We have to decide whether we want to keep the RawCalorimeterHit in EDM4hep or whether we want to remove it and declare the (calibrated) CalorimeterHit as entry point for reconstruction in EDM4hep.

gaede commented 3 months ago

We (BH, JMC, FG) suggest to drop the RawCalorimeterHit for now. (Only add/keep if we find current code that uses it).

jmcarcell commented 3 months ago

This is used in the dual-readout repo: https://github.com/HEP-FCC/dual-readout/blob/master/DRsim/DRsimG4Components/include/SimG4SaveDRcaloHits.h#L33

tmadlener commented 3 months ago

Since this is used, we keep it for now. Potentially add an Association if necessary later.