search

key4hep / EDM4hep

Generic event data model for HEP collider experiments
https://cern.ch/edm4hep
Apache License 2.0
25 stars 35 forks source link

Remove `radiusOfInnermostHit` from tracks #326

Closed jmcarcell closed 3 months ago

jmcarcell commented 3 months ago

as discussed in https://github.com/key4hep/EDM4hep/issues/319.

Changes in other repos:

BEGINRELEASENOTES

ENDRELEASENOTES

tmadlener commented 3 months ago

The fact that this requires changes in k4SimDelphes makes me think this will also show up in some analyses in FCCAnalyses, but I haven't checked.

jmcarcell commented 3 months ago

I checked and didn't find anything in FCCAnalyses

tmadlener commented 3 months ago

OK. Then maybe it was there only temporarily, or we just filled it in k4SimDelphes because we could. Thanks for checking.

hegner commented 3 months ago

Perfect. Good we checked this again :)

hegner commented 3 months ago

can we maybe finally fix the release build test environment? Otherwise I am fine with merging

tmadlener commented 3 months ago

Fixing the release build would require a new Key4hep release. For EDM4hep we could in principle pick up the latest podio tag, but for other packages, we would also need a new EDM4hep tag. I am not sure if we want to make such a tag at the moment.