Closed brauliorivas closed 3 months ago
PR Preview Action v1.4.7 :---: Preview removed because the pull request was closed. 2024-07-17 15:16 UTC
Hi Braulio, very nice. This doesn't address #47 yet though. What was desired there is that the bitfield is parsed to get the bits out for easier interpretation. I.e. (in python)
def parse_bits(bitfield):
bits = []
# assuming here that it's a 32 bit wide number, maybe we need 64 as well?
for i in range(32):
if (bitfield & (0x1 << i)):
bits.append(i)
return bits
status = 1493172224
status_bits = parse_bits(status)
# [24, 27, 28, 30]
and that could then be used to get the actual strings from this map: https://github.com/key4hep/eede/blob/bc2b522a81cbbc44816da2bf0bae875045bfb37e/js/menu/filter/filter.js#L63-L72
For the box view we could just use the first character and then the mouse-over could have the full strings for example.
Hi Braulio, very nice. This doesn't address #47 yet though. What was desired there is that the bitfield is parsed to get the bits out for easier interpretation. I.e. (in python)
Oh, I forgot about this, we implemented it for the filters. Thank you for explaining it again. Right now, the first character is shown on the box and the full name when mouse over, just like described above. (the original bit field is shown on the box if no parsed bit matches the strings on the map, and no name is shown on mouse over).
Very nice, especially the mouse-over with the full strings. Extremely minor nit-pick, I would remove the commas to save space
based on #58 BEGINRELEASENOTES
mousemove
event has been modified, so it also checks whether the mouse is over an object. When it is, at the top of the particle, it is shown a small text, indicating the collection name to where the object belongs.ENDRELEASENOTES