Incorporate suggested changes for tree views and list views

key4hep / eede

EDM4hep Event Data Explorer

https://key4hep.github.io/eede/

BSD 2-Clause "Simplified" License

3 stars 4 forks source link

Incorporate suggested changes for tree views and list views #79

Closed brauliorivas closed 1 month ago

brauliorivas commented 1 month ago

BEGINRELEASENOTES

In our last gsoc meeting on Aug 9, we discussed changing the views for ParticleId and Reco Tree.
In the case of ParticleId (and any view that is a list), there was the case that if not enough elements, when showing from left to right, it would be hard to visualize because are aligned to left. Instead, now it will be centered, so it's easier to view elements that are in the last row.
For the case of tree views, like RecoParticle Tree, there are a lot of elements that are not connected to anything, so they'll be in a large row. Instead, tree views are combined with list views, so those objects that aren't connected to anything, will show as a list, and later on, the tree.

ENDRELEASENOTES

github-actions[bot] commented 1 month ago

PR Preview Action v1.4.7 :---: Preview removed because the pull request was closed. 2024-08-14 19:39 UTC

kjvbrt commented 1 month ago

Hi @brauliorivas, I like the changes: :)

when trying particle ID list I get however halves of infoboxes on the right side: Do you use width of the screen to determine number of elements in the row? Or this is just a coincidence?

brauliorivas commented 1 month ago

when trying particle ID list I get however halves of infoboxes on the right side:

Oh, didn't see it coming. This new line would allow to add or not one last column, but making sure won't show the halve of the box.

Do you use width of the screen to determine number of elements in the row? Or this is just a coincidence?

Yes, I use the width of the screen.

kjvbrt commented 1 month ago

Now it look better, but there is still shift in the array by half of the width of the box to the left. Can you center the infoboxes horizontally? :)

kjvbrt commented 1 month ago

Hi @brauliorivas,this looks nice now. merging this...