key4hep / k4ActsTracking

Acts integration in the key4hep framework
Apache License 2.0
1 stars 7 forks source link

Add CI tests and update to newer ACTS #13

Closed Zehvogel closed 1 year ago

Zehvogel commented 1 year ago

BEGINRELEASENOTES

ENDRELEASENOTES

andresailer commented 1 year ago

Can you add pre-commit and license while you are at it?

andresailer commented 1 year ago

@paulgessinger Are you OK with the Apache 2 License?

Zehvogel commented 1 year ago

Build test is waiting for https://github.com/key4hep/key4hep-spack/pull/522 as Acts is unfortunately built without the dd4hep plugin in key4hep atm..

[lreichen@pcphsft121 acts]$ ll /cvmfs/sw-nightlies.hsf.org/key4hep/releases/2023-06-24/x86_64-centos7-gcc12.2.0-opt/acts/23.2.1-rk7msr/include/Acts/
total 42
-rw-r--r--. 1 cvmfs cvmfs 1036 Jun 25 08:46 ActsVersion.hpp
drwxr-sr-x. 2 cvmfs cvmfs   58 Jun 25 08:48 Clusterization
drwxr-sr-x. 2 cvmfs cvmfs  113 Jun 25 08:48 Definitions
drwxr-sr-x. 2 cvmfs cvmfs  217 Jun 25 08:48 Digitization
drwxr-sr-x. 3 cvmfs cvmfs 4096 Jun 25 08:48 EventData
drwxr-sr-x. 3 cvmfs cvmfs 4096 Jun 25 08:48 Geometry
drwxr-sr-x. 3 cvmfs cvmfs  248 Jun 25 08:48 MagneticField
drwxr-sr-x. 3 cvmfs cvmfs 4096 Jun 25 08:48 Material
drwxr-sr-x. 3 cvmfs cvmfs 4096 Jun 25 08:48 Propagator
drwxr-sr-x. 2 cvmfs cvmfs 4096 Jun 25 08:48 Seeding
drwxr-sr-x. 3 cvmfs cvmfs  120 Jun 25 08:48 SpacePointFormation
drwxr-sr-x. 3 cvmfs cvmfs 4096 Jun 25 08:48 Surfaces
drwxr-sr-x. 2 cvmfs cvmfs  153 Jun 25 08:48 TrackFinding
drwxr-sr-x. 3 cvmfs cvmfs  282 Jun 25 08:48 TrackFitting
drwxr-sr-x. 3 cvmfs cvmfs 4096 Jun 25 08:48 Utilities
drwxr-sr-x. 2 cvmfs cvmfs 4096 Jun 25 08:48 Vertexing
drwxr-sr-x. 3 cvmfs cvmfs  183 Jun 25 08:48 Visualization
paulgessinger commented 1 year ago

The other PR is merged but it seems like it's still failing to find the the plugin?

Zehvogel commented 1 year ago

We only expect the nightlies to pass and they do now. It will take until the next release for the other one...

Zehvogel commented 1 year ago

currently waiting for the opendatadetector to become available in the nightlies, it should be there tomorrow. Then we can use it directly in the ci without building it ourselves every time

paulgessinger commented 1 year ago

@Zehvogel I see, where is this built then? I'm wondering if keeping this in sync is really worth it since building it does not take a long time normally.

Zehvogel commented 1 year ago

@Zehvogel I see, where is this built then? I'm wondering if keeping this in sync is really worth it since building it does not take a long time normally.

@paulgessinger Is your question where the ODD is built? We added it to the key4hep-stack. At the moment we build the last tagged version, but we could also add it properly to the key4hep nightlies and have the latest main all the time...