key4hep / k4ActsTracking

Acts integration in the key4hep framework
Apache License 2.0
1 stars 7 forks source link

Use GeoSvc to get dd4hep geometry instead of loading it ourselves #17

Closed Zehvogel closed 12 months ago

Zehvogel commented 1 year ago

BEGINRELEASENOTES

ENDRELEASENOTES

resolves #16

Zehvogel commented 1 year ago

looks like the acts dd4hep plugin tries to also convert the calorimeters and fails doing that. After that there are no tracking surfaces... Commenting out the calorimeter in the ODD fixes this locally but there must be another way as this does not show up in the usage of the ODD by acts elsewhere? @paulgessinger?

[ctest] 1: 13:18:26    k4ActsTracki   INFO      Translating DD4hep geometry into Acts geometry
[ctest] 1: 13:18:26    k4ActsTracki   INFO      Translating DD4hep sub detector: BeamPipe
[ctest] 1: 13:18:26    k4ActsTracki   INFO      Translating DD4hep sub detector: Pixels
[ctest] 1: 13:18:26    k4ActsTracki   INFO      Translating DD4hep sub detector: PST
[ctest] 1: 13:18:26    k4ActsTracki   INFO      Translating DD4hep sub detector: ShortStrips
[ctest] 1: 13:18:26    k4ActsTracki   INFO      Translating DD4hep sub detector: LongStrips
[ctest] 1: 13:18:26    k4ActsTracki   INFO      Translating DD4hep sub detector: Solenoid
[ctest] 1: 13:18:26    k4ActsTracki   INFO      Translating DD4hep sub detector: ECal
[ctest] 1: 13:18:26    k4ActsTracki   INFO      Translating DD4hep sub detector: HCal
[ctest] 1: 13:18:27    D2A_V:ECal     ERROR     Misconfiguration in volume building detected
paulgessinger commented 1 year ago

In the other ODD workflows, ACTS ignores the calorimeters once it determines that there are no sensitive surfaces that it can pick up. I added that in https://github.com/acts-project/acts/pull/2514

Zehvogel commented 1 year ago

Thx! It looks like we are still on acts 28.2.0 I will lobby to get a newer version...