Fix typo in type check - Githubissues

key4hep / k4EDM4hep2LcioConv

EDM4hep <-> LCIO Converter

1 stars 11 forks source link

Fix typo in type check #83

Closed Zehvogel closed 3 months ago

Zehvogel commented 3 months ago

BEGINRELEASENOTES

Fix a typo in the type checks for creating Associations between TrackerHits and SimTrackerHits.

ENDRELEASENOTES

Originally introduced in #76

tmadlener commented 3 months ago

Thanks.

tmadlener commented 3 months ago

Looking at this again, I am not sure if this is the entire fix. There are still two distinct maps for handling TrackerHit3D and TrackerHitPlane in the converter, and from the looks of it, only one of them gets passed here for creating the associations. Given that the typo is definitely a bug, I will merge this now and we fix the rest in a follow up PR.

Zehvogel commented 3 months ago

Looking at this again, I am not sure if this is the entire fix. There are still two distinct maps for handling TrackerHit3D and TrackerHitPlane in the converter, and from the looks of it, only one of them gets passed here for creating the associations. Given that the typo is definitely a bug, I will merge this now and we fix the rest in a follow up PR.

I fully agree :)