search

key4hep / k4FWCore

Core Components for the Gaudi-based Key4hep Framework
Apache License 2.0
10 stars 26 forks source link

Remove the deprecated lcdd() from GeoSvc Interface #176

Closed kjvbrt closed 8 months ago

kjvbrt commented 9 months ago

BEGINRELEASENOTES

ENDRELEASENOTES

kjvbrt commented 9 months ago

I already merged https://github.com/HEP-FCC/k4SimGeant4/pull/58

jmcarcell commented 9 months ago

The downstream-build workflow is failing because lcdd is still used by the dual-readout repo

kjvbrt commented 9 months ago

Reverting https://github.com/HEP-FCC/k4SimGeant4/pull/58 for now.

kjvbrt commented 8 months ago

Removing lcdd() from k4SimGeant4 again. Downstream test should pass now. https://github.com/HEP-FCC/k4SimGeant4/pull/66

jmcarcell commented 8 months ago

This looks fine now, some tests fail in fccsw but they are broken because of other reasons