Use setMomentum for particles

key4hep / k4FWCore

Core Components for the Gaudi-based Key4hep Framework

Apache License 2.0

10 stars 26 forks source link

Use setMomentum for particles #185

Closed jmcarcell closed 6 months ago

jmcarcell commented 6 months ago

BEGINRELEASENOTES

Use setMomentum for particles, fixing an issue when trying to change a const reference

ENDRELEASENOTES

I'm not sure what has changed since I think that has been there for a time but the reference from getMomentum should be const. Locally I don't need this fix with clang 17 and I can't reproduce the error when building on top of the latest nightlies (that are picking up EDM4hep from a few days ago) but on spack I can reproduce consistently

tmadlener commented 6 months ago

What has changed is this: https://github.com/AIDASoft/podio/pull/553 (which is not part of podio v00-99)

edit: I am in any case all for the solution that is implemented here as the canonical approach for this.

jmcarcell commented 6 months ago

But that PR was merged on Feb 15 and the nightly build on Feb 16 is using master in podio and main in k4FWCore