Closed tmadlener closed 3 months ago
It looks like this has a rather small impact on downstream code, so I would be in favor of having this as a breaking change, i.e. the std::optional
appearing in the return type.
I'm fine with that, k4FWCore doesn't build anyway on the latest release, so not much is going to change
Now I have to introduce pre processor checks here and check that it works for podio @0.99 as well as once #580 is merged. I will be coming back to this a bit later (i.e. probably tomorrow).
Anything still missing from here, or can we merge this?
Merging this, since this is not transparent and we need to unblock AIDASoft/podio#580
BEGINRELEASENOTES
MetaDataHandle::get
throw an exception in case the value for the handle is not (yet) available.MetaDataHandle::get(T defaultValue)
overload to get a default value and no exception in case the value is not (yet) available.MetaDataHandle::get_optional()
to retrieve an optional that is engaged and holds the value if the handle already has a value available.ENDRELEASENOTES
~I have for now opted to let the underlying change in podio shine through here. I think having an
optional
value forMetaDataHandle::get
offers the same benefits as having it on theFrame
in the first place, as otherwise there is no way of distinguishing between empty and unset values.~