key4hep / k4FWCore

Core Components for the Gaudi-based Key4hep Framework
Apache License 2.0
10 stars 26 forks source link

Make MetaDataHandle::get throw in case the value is not available and add more overloads #195

Closed tmadlener closed 3 months ago

tmadlener commented 4 months ago

BEGINRELEASENOTES

ENDRELEASENOTES

~I have for now opted to let the underlying change in podio shine through here. I think having an optional value for MetaDataHandle::get offers the same benefits as having it on the Frame in the first place, as otherwise there is no way of distinguishing between empty and unset values.~

tmadlener commented 4 months ago

It looks like this has a rather small impact on downstream code, so I would be in favor of having this as a breaking change, i.e. the std::optional appearing in the return type.

jmcarcell commented 3 months ago

I'm fine with that, k4FWCore doesn't build anyway on the latest release, so not much is going to change

tmadlener commented 3 months ago

Now I have to introduce pre processor checks here and check that it works for podio @0.99 as well as once #580 is merged. I will be coming back to this a bit later (i.e. probably tomorrow).

tmadlener commented 3 months ago

Anything still missing from here, or can we merge this?

tmadlener commented 3 months ago

Merging this, since this is not transparent and we need to unblock AIDASoft/podio#580