key4hep / k4FWCore

Core Components for the Gaudi-based Key4hep Framework
Apache License 2.0
10 stars 26 forks source link

Add an algorithm for merging collections #209

Closed jmcarcell closed 1 month ago

jmcarcell commented 2 months ago

BEGINRELEASENOTES

ENDRELEASENOTES

jmcarcell commented 2 months ago

There are many caveats with this one since you can drop collections that contain the information that you need, with and without copying, so the usage has to be studied a bit more. On relations, I thought about implementing copying of the relations to the new ones but it's not trivial since it has to be done for each collection independently and for now I think I won't implement it unless it's needed. In any case if the usage of this is to use it before an algorithm then to get some collections merged into one and then never use it again it should be fine. If the usage pick collections from a file and make a new file with only the merged one then it won't work as it is.

tmadlener commented 2 months ago

Yes, I agree. We should just write these down as long as we still have them in mind. Who knows how many of these we remember in half a year ;)

jmcarcell commented 1 month ago

I'll start by merging this one today before there are too many conflicts with other PRs