search

key4hep / k4FWCore

Core Components for the Gaudi-based Key4hep Framework
Apache License 2.0
10 stars 26 forks source link

Duplicate interface ? #216

Open giovannimarchiori opened 3 months ago

giovannimarchiori commented 3 months ago

It looks to me that INoiseConstTool and ICaloReadCellNoiseMap provide essentially the same interface, i.e. getters for noise RMS and offset given cellID - if that's the case we could get rid of one of the two (adjusting the code that uses one or the other)

tmadlener commented 3 months ago

I haven't looked at either of them, but if it's possible to remove duplication I am all for it. If you are able to prepare a PR that removes one of them, I could check whatever breaks in other packages / downstream.