Move to new link types to keep compatibility with EDM4hep in the future

key4hep / k4FWCore

Core Components for the Gaudi-based Key4hep Framework

Apache License 2.0

10 stars 26 forks source link

Move to new link types to keep compatibility with EDM4hep in the future #217

Closed tmadlener closed 1 month ago

tmadlener commented 1 month ago

BEGINRELEASENOTES

Add the legacy AssociationCollection headers to keep things building after https://github.com/key4hep/EDM4hep/pull/341 has been merged

ENDRELEASENOTES

tmadlener commented 1 month ago

@jmcarcell I would merge this after confirming it doesn't break anything in CI and then trigger the downstream build in https://github.com/key4hep/EDM4hep/pull/341 again

jmcarcell commented 1 month ago

Hmm I'm not sure if we should bother with an intermediate step, we are already incompatible with the last release so just switching to the new names shouldn't cause more issues, I guess you just want to see how it affects other repos? But then with the workflow is going to take a while :smiley:

tmadlener commented 1 month ago

I can also just move to the new types directly, and check locally. That would then tie this PR strictly to the EDM4hep one.

jmcarcell commented 1 month ago

Yeah, I think in general since we are not compatible anyway with an older version we can move directly for this and other repos. More work upfront but it will be done.

tmadlener commented 1 month ago

Things are building locally with this and key4hep/EDM4hep#341 for me. So from my side we can go ahead and merge them both.