search

key4hep / k4GeneratorsConfig

0 stars 1 forks source link

Inheritance #10

Closed dirkzerwas closed 2 months ago

dirkzerwas commented 2 months ago

BEGINRELEASENOTES

ENDRELEASENOTES

dirkzerwas commented 2 months ago

Added some bugfixes:

A general question should hepmc or hepmc3 be the default?

apricePhy commented 2 months ago

I would say hepmc3, it is more the 5 years old now and the default for many. I think its somewhat backwards compatible anyway

On 12. Apr 2024, at 09:35, Dirk Zerwas @.***> wrote:

Added some bugfixes:

A general question should hepmc or hepmc3 be the default?

— Reply to this email directly, view it on GitHubhttps://github.com/key4hep/k4GeneratorsConfig/pull/10#issuecomment-2051187363, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BC3NHSDHH5ZZBZPX5GTTIWDY46FF5AVCNFSM6AAAAABGCOZSRKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJRGE4DOMZWGM. You are receiving this because your review was requested.Message ID: @.***>

dirkzerwas commented 2 months ago

ok, I will move the default and modify the examples and references for hepmc3 in this branch

dirkzerwas commented 2 months ago

Hi @apricePhy, is there a difference internally between EVENT_OUTPUT HepMC_GenEvent(name) and HepMC3_GenEvent(name)? For HepMC2 : sherpa outputs: name.hepmc2g for HepMC3: name (cured by adding ".hepmc3g" to the argument of Hep, seems to work (CI running)

apricePhy commented 2 months ago

This is a common sherpa argument as to wether we should provide the ext or the user. One camp did hepmc2 and the other hepmc3

I will ask that we at least be consistent between hepmc2/3 and port the correction.

On 12. Apr 2024, at 17:10, Dirk Zerwas @.***> wrote:

Hi @apricePhyhttps://github.com/apricePhy, is there a difference internally between EVENT_OUTPUT HepMC_GenEvent(name) and HepMC3_GenEvent(name)? For HepMC2 : sherpa outputs: name.hepmc2g for HepMC3: name (cured by adding ".hepmc3g" to the argument of Hep, seems to work (CI running)

— Reply to this email directly, view it on GitHubhttps://github.com/key4hep/k4GeneratorsConfig/pull/10#issuecomment-2051951670, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BC3NHSGPK4XZI4T7R273GGLY472PPAVCNFSM6AAAAABGCOZSRKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJRHE2TCNRXGA. You are receiving this because you were mentioned.Message ID: @.***>

dirkzerwas commented 2 months ago

Great, switching to HepMC3 for sherpa we see the line: WARNING::GenCrossSection::to_string: the number of cross-sections cross_sections.size()=1 does not match the number of weights5 but only once and not once per event (as for whizard) maybe the first write is affected?

apricePhy commented 2 months ago

Odd, in sherpa2 we dont have any physical additional “weights” but some process info that hepmc sees as weights and requires an xs. So we just set the nominal xs for each additional “Weight”. Not sure there should be even one warning!

https://gitlab.com/sherpa-team/sherpa/-/merge_requests/742

On 12. Apr 2024, at 17:36, Dirk Zerwas @.***> wrote:

Great, switching to HepMC3 for sherpa we see the line: WARNING::GenCrossSection::to_string: the number of cross-sections cross_sections.size()=1 does not match the number of weights5 but only once and not once per event (as for whizard) maybe the first write is affected?

— Reply to this email directly, view it on GitHubhttps://github.com/key4hep/k4GeneratorsConfig/pull/10#issuecomment-2051994308, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BC3NHSGZDVRLYHBAF3DAHG3Y475O5AVCNFSM6AAAAABGCOZSRKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJRHE4TIMZQHA. You are receiving this because you were mentioned.Message ID: @.***>