key4hep / k4GeneratorsConfig

0 stars 1 forks source link

[Whizard] fix two bugs for W-bosons #15

Closed Zehvogel closed 2 months ago

Zehvogel commented 2 months ago

BEGINRELEASENOTES Fixed two bugs for W-bosons

ENDRELEASENOTES

apricePhy commented 2 months ago

Thanks Leonhard

Zehvogel commented 2 months ago

That merge was maybe a bit quick? :D It looks like I broke this test:

Checking Run-Cards/Whizard
Process  Difermion_Polarized Files are different for file Difermion_Polarized_ISR_BST.sin
16,17c16,17
< mW = 80.379
< wW = 2.085
---
> mWp = 80.379
> wWp = 2.085
20a21,22
> mW = 80.419 GeV
> wW = 2.0476 GeV

0% tests passed, 1 tests failed out of 1
apricePhy commented 2 months ago

It "broke" in the right direction. The reference files have to be updated but I will take care of that.

Zehvogel commented 2 months ago

No I think that part should still set mW not mWp it is because I did not touch https://github.com/key4hep/k4GeneratorsConfig/blob/3ff7b6130bab4d5d2e58d976d197fcc3dd500990/python/Generators/Whizard.py#L76 It should be enough to add m, and p there (if that does not break something else in turn)

Zehvogel commented 2 months ago

I saw that you added that change but it did indeed manage to break something else, sorry :(

 < mtop = 173
< wtop = 1.4915
---
> mto = 173
> wto = 1.4915
apricePhy commented 2 months ago

Thanks for catching this. I was not aware that whizard had a different naming convention for the "heavy" particles. Should be resolved now