add the radius of the innermost hit to the tracks

key4hep / k4SimDelphes

Apache License 2.0

3 stars 13 forks source link

add the radius of the innermost hit to the tracks #80

Closed EmanuelPerez closed 2 years ago

EmanuelPerez commented 2 years ago

BEGINRELEASENOTES

to be used with Delphes 3.5.1pre02 or later
fill the "radiusOfInnermostHit" member of edm4hep tracks using the position of the first hit, which is now part of the Delphes tracks

ENDRELEASENOTES

clementhelsens commented 2 years ago

Hi @EmanuelPerez,

this is in fact already in this PR where other things were added: https://github.com/vvolkl/k4SimDelphes/pull/1/files#diff-403b9553e4a02dcdbd1c8415110dcdd7cd2281c4a3ccc60ace3bba88265048ebR235

tmadlener commented 2 years ago

Hi @clementhelsens the PR you pointed to above is targeting a fork of this repository. I am not sure if that is intended or not.

clementhelsens commented 2 years ago

Hi @tmadlener , yes that was intended as we could consider merging the PR I pointed to to also include other things (dNdx and path length as user data and first/last trackerHits position and time) EDIT: merging to the base repo and not only in @vvolkl fork

tmadlener commented 2 years ago

OK. I see. I will let you decide then which one should go in in the end. If it should be this one there are merge conflicts that need to be resolved first though.

tmadlener commented 2 years ago

This one is now superseded by #81, right?

clementhelsens commented 2 years ago

exactly!

clementhelsens commented 2 years ago

Closing we just merged #81