search

key4hep / k4geo

DD4hep based geometry models for lepton collider detectors (Formerly known as lcgeo)
GNU General Public License v3.0
8 stars 57 forks source link

CLD tracker endcaps too small in CED #355

Closed Zehvogel closed 4 weeks ago

Zehvogel commented 1 month ago

They are the right size in geoDisplay. @gaede @tmadlener you recently fixed the shape, do you also have an idea what we can do about the size? :)

The outer radius should roughly match the grey lines

image

tmadlener commented 1 month ago

I tried to figure out where the necessary changes would need to happen, resp. where the issue could actually be, but I am not yet sure which part of the whole CED ecosystem is actually responsible for drawing the detector.

Zehvogel commented 1 month ago

Ah sorry I could have provided a bit more info. I would guess that there is still something wrong with the ZDiskPetalsData used here to determine the dimensions for drawing.

https://github.com/iLCSoft/MarlinUtil/blob/bde10dc7da50a22503b0593f9188d2be047fbebf/source/src/DDMarlinCED.cc#L582-L597