key4hep / key4hep-spack

A Spack recipe repository of Key4hep software.
10 stars 24 forks source link

Recognize Scientific Linux 7. #552

Closed scott-snyder closed 11 months ago

scott-snyder commented 11 months ago

Scientific Linux 7 identifies itself as RHEL. Test for that as well as Centos7 in the setup scripts.

BEGINRELEASENOTES

scott-snyder commented 11 months ago

hi -

We've been running FCC software on the BNL analysis facility. This is presently running Scientific Linux 7.3:

$ cat /etc/redhat-release
Scientific Linux release 7.3 (Nitrogen)

This causes the supplied k4hep setup script to fail:

$ . /cvmfs/sw.hsf.org/key4hep/setup.sh
Unsupported OS or OS couldn't be correctly detected, aborting...

The script does support centos7. However, SL7 identifies itself as rhel, not centos:

$ cat /etc/os-release 
NAME="Scientific Linux"
VERSION="7.3 (Nitrogen)"
ID="rhel"
ID_LIKE="fedora"
VERSION_ID="7.3"
PRETTY_NAME="Scientific Linux 7.3 (Nitrogen)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:scientificlinux:scientificlinux:7.3:GA"
HOME_URL="http://www.scientificlinux.org//"
BUG_REPORT_URL="mailto:scientific-linux-devel@listserv.fnal.gov"

REDHAT_BUGZILLA_PRODUCT="Scientific Linux 7"
REDHAT_BUGZILLA_PRODUCT_VERSION=7.3
REDHAT_SUPPORT_PRODUCT="Scientific Linux"
REDHAT_SUPPORT_PRODUCT_VERSION="7.3"

For 9, the script does detect both rhel and almalinux.

Updating it to recognize rhel7 as well as centos7 fixes the issue.