search

key4hep / key4hep-spack

A Spack recipe repository of Key4hep software.
10 stars 23 forks source link

Remove pandorapfa and pandorasdk since they have been upstreamed #593

Closed jmcarcell closed 4 months ago

jmcarcell commented 4 months ago

in https://github.com/spack/spack/pull/37714

Does it matter @wdconinc if I remove then here now? For me either waiting for the next time I pick a more recent version of spack or removing it now and cherry picking the changes from spack both are fine.

wdconinc commented 4 months ago

It's been in spack for 3 months already, so it is probably already in the version you use. No preference for how you handle it since we pick up the spack version.

jmcarcell commented 4 months ago

Ah true, I don't know why I just came back to this and expected something (an error message?) when there is a package that appears both in upstream and in our own repo but it doesn't look like there is one. I'll merge this then.

wdconinc commented 4 months ago

Depends on the repository ordering in spack config blame repos, but even then the packages are largely identical from what I recall, so it shouldn't have been a visible change.