key4hep / key4hep-spack

A Spack recipe repository of Key4hep software.
10 stars 24 forks source link

Add k4GeneratorsConfig package and include it in key4hep-stack #617

Closed tmadlener closed 1 month ago

tmadlener commented 3 months ago

Just to not forget about this.

@dirkzerwas FYI

BrieucF commented 1 month ago

Hi,

First, congrats on the initiative, this will be extremely useful to many!

I'd like to re-open this issue because:

dirkzerwas commented 1 month ago

Hi @BrieucF! thank you @jmcarcell for the implementation!

Maybe this line: env.set("K4GENERATORSCONFIG", self.prefix.share.k4geo) should rather be: env.set("K4GENERATORSCONFIG", self.prefix.share.k4generatorsconfig) though I do not know if and where self.prefix.share.k4generatorsconfig is set?

For the executable (@apricePhy): we can change the alias k4gen to k4generatorsConfig (or something else) to avoid confusion.

Can spack run the "source setup.sh" in k4GeneratorsConfig, then you would have the alias?

tmadlener commented 1 month ago

Looking into things a bit, I found the following:

Can spack run the "source setup.sh" in k4GeneratorsConfig, then you would have the alias?

Not easily, but we can do everything that is done there in the package.py

dirkzerwas commented 1 month ago

ok: the alias is updated.

tmadlener commented 1 month ago

I am happy to remove setup.* if this can go to package.py

We can just have both. Having a setup.sh usually makes it a bit easier to setup an environment for a local installation.

dirkzerwas commented 1 month ago

share added and CMakeList.txt updated to install it , thanks @tmadlener

BrieucF commented 1 month ago

Thanks!