Key4hep won't pull in python 3.11

key4hep / key4hep-spack

A Spack recipe repository of Key4hep software.

10 stars 24 forks source link

Key4hep won't pull in python 3.11 #624

Closed joequant closed 1 month ago

joequant commented 2 months ago

!!!IMPORTANT!!!: To facilitate faster and easier response to your issue please provide in addition to the description of the issue also the following information

OS version: Mageia Linux
Compiler version: GCC 14.0
Package version: 1cd6239
Reproduced by: exact steps to reproduce the problem: checkout, setup environment (ROOT versions, LCG release), cmake, build, run...

spack spec key4hep-stack

The preferred version of python is 3.11.9 but when I try to build key4hep-stack it pulls in python 3.10.14

Trying to figure out why, and ideas for debugging.

joequant commented 2 months ago

Its a dependency on py-protobuf+cpp

jmcarcell commented 2 months ago

Yeah I checked once and remember reaching the same conclusion, it was impossible to have python 3.11 having a single version of protobuf. One possible option would be to have py-torch install its own protobuf, it's even commented here: https://github.com/spack/spack/blob/814f4f20c0dda13cc5668bb26ef9d09e876a5d75/var/spack/repos/builtin/packages/py-torch/package.py#L107-L109, but I haven't tried this yet.

jmcarcell commented 1 month ago

This shouldn't happen anymore after making pytorch install its own protobuf (because of strong requirements on the protobuf version otherwise) and https://github.com/spack/spack/pull/46434. I'm building the next release and it's correctly installing 3.11.9 (probably could also be 3.12 but there is another requirement that is being looked at). The next time the nightlies are built from scratch they will have at least 3.11.9.