key4hep / key4hep-spack

A Spack recipe repository of Key4hep software.
10 stars 24 forks source link

update onnx to 1.16.1 for gcc14 compatibility #645

Closed joequant closed 1 month ago

joequant commented 2 months ago

BEGINRELEASENOTES

tmadlener commented 2 months ago

Does this impact the version requirements for py-onnxruntime?

jmcarcell commented 2 months ago

Yes, py-onnx needs to be updated together with py-onnxruntime. And in this case, what's wrong with version 1.15 that is solved in 1.16? I have an installation with GCC 14 after https://github.com/spack/spack/pull/46390, which is related to dependencies. With this PR it would still be impossible to build with GCC 14 since it requires protobuf+cpp and +cpp has a conflict with GCC 14.

jmcarcell commented 1 month ago

Closing, versions will be updated the next time the nightlies are built from scratch of both py-onnx and py-onnxruntime.