Ignore implicit memberships in Requester.getAllTeams

keybase / bot-sshca

A chat bot that can manage your team's SSH accounts

BSD 3-Clause "New" or "Revised" License

222 stars 30 forks source link

Ignore implicit memberships in Requester.getAllTeams #101

Closed zapu closed 4 years ago

zapu commented 4 years ago

When current user is an implicit admin in any team, loading kssh configs from Keybase KV store will fail for that team, failing the entire process. KV store is not available unless the user is an explicit member. This PR changes Requester.getAllTeams to skip teams where user is not an explicit member.

zapu commented 4 years ago

This probably needs a test or something similar, I've yet to figure out how to do that though. Seems to be working locally, though.

zapu commented 4 years ago

yep thx! I'm still on this but something else also came up today

zapu commented 4 years ago

@mmou hey, I changed some things around here and also tested the entire thing using couple of virtual machines and it seems to work! My real account also hit this bug because it's an implicit admins for some subteams.