keybase / bot-sshca

A chat bot that can manage your team's SSH accounts
BSD 3-Clause "New" or "Revised" License
222 stars 30 forks source link

Add KEYBASE_TIMEOUT configuration parameter to configure a custom timeout for interacting with the bot #92

Closed ddworken closed 4 years ago

ddworken commented 4 years ago

Some users (#91) were having difficulties with timeouts if running the CA bot on a slow computer with a high latency internet connection. In order to fix this, add a new configuration parameter that can be used to change the timeout. In order to do so, also had to update out dependencies to pull in the latest KB chat library (keybase/go-keybase-chat-bot#67).

The library also changed the arg order to a function, so swapped that in our code to make everything continue to work.

This changes the timeouts for KB chat and for the Keybase service, so it should also fix #90

ddworken commented 4 years ago

@blaggacao can you give this a try and see whether tweaking the KEYBASE_TIMEOUT config will fix your issue? I tried running the bot on my own ARM server and wasn't able to reproduce your timeout issues, but I think this should help.

mmou commented 4 years ago

thanks for your work on this @ddworken! a heads up - aiming to get this in in the next hour just so it's easier for me to start on another PR that includes this PR's keybase version bump.

ddworken commented 4 years ago

Sounds good! Thanks for the heads up :+1: