search

keybase / client

Keybase Go Library, Client, Service, OS X, iOS, Android, Electron
BSD 3-Clause "New" or "Revised" License
8.92k stars 1.23k forks source link

macOS client app looses track of state #10517

Open hwine opened 6 years ago

hwine commented 6 years ago

I can end up with a "useless" macOS client application -- it's not logged in, and there's no way to get to the login screen. (Originally mis posted as part of another bug.)

Sometimes, a stack trace is displayed on the app's screen (see below).

STR:

  1. log into keybase via the app
  2. quit the app
  3. go to a terminal and logout from CLI
  4. start keybase app not from the toolbar (I used Spotlight)
  5. app starts on "logged in" screen, no way to get to login.

Workaround:

screen shot 2018-02-11 at 16 34 08

maxtaco commented 6 years ago

cc: @keybase/react-hackers

timfallmk commented 6 years ago

@hwine Does this happen if you run keybase ctl app-exit before relaunching the GUI app?

If so I suspect it's that react is not getting a logout event and presenting the wrong pane, as @maxtaco tagged.

hwine commented 6 years ago

Does this happen if you run keybase ctl app-exit before relaunching the GUI app?

@timfallmk No -- issuing the ctl app-exit allows the KeyBase app to start with the login screen.

If so I suspect it's that react is not getting a logout event and presenting the wrong pane, as @maxtaco tagged.

Is react even running at the time of the logout? (The app has already been exited in step 2.) Maybe the CLI logout process also needs to invoke ctl app-exit?

timfallmk commented 6 years ago

@hwine Sorry, I should have been more specific. If keybase ctl app-exit does the correct thing (which it sounds like it does), then in the bug case the problem is likely due to a (missing) react event on logouts.

hwine commented 6 years ago

Yah - I had trouble with the double negative. To be explicit keybase ctl app-exit does fix the issue.