search

keybase / client

Keybase Go Library, Client, Service, OS X, iOS, Android, Electron
BSD 3-Clause "New" or "Revised" License
8.91k stars 1.23k forks source link

Auto-filled Reddit proof is completely broken on Reddit redesign #11624

Open ghost opened 6 years ago

ghost commented 6 years ago

You end up getting a ton of +'s everywhere and Keybase just keeps reporting 'Failed' until you edit the link to go to 'old.reddit.com', once you do that everything magically works.

pl4nty commented 6 years ago

I had this issue too, seems like they are aware:

// Reddit interprets plusses in the query string differently depending
// on whether the user is using the old or new (2018) design, and
// on whether it's the title or body of the post.
// old,     *, '+'   -> ' '
// old,     *, '%2B' -> '+'
// new, title, '+'   -> ' '
// new, title, '%2B' -> ' '
// new,  body, '+'   -> '+'
// new,  body, '%2B' -> '+'

// Examples:
// https://www.reddit.com/r/test/submit?text=content+fmt%0Aplus+x%2By%20z&title=title+fmt%0Aplus+x%2By%20z
// old: https://www.reddit.com/r/test/comments/8eee0e/title_fmt_plus_xy_z/
// new: https://www.reddit.com/r/test/comments/8eelwf/title_fmt_plus_x_y_z/

// Replace '(', ")" and "'" so that URL-detection works in Linux
// Padding is not needed now, but might be in the future depending on
// changes we make

Not sure if it's PR worthy but definitely annoying since it fails so silently. EDIT: didn't realise I was necroing this issue, but will leave my comment since the info took a while to find

maxtaco commented 6 years ago

I think we fixed this a while ago, are you sure it's broken on recent releases?